afi / afi · cli reviewed proxy at 9b51f95e with Default profile / OpenAI · gpt 5.6 sol high on afi 0.30.0
Unavailable values retain their exported state and reason
Lifecycle, reviewer, build, settings, and normalized execution limits
89cd13e3b4e0config-323a87a9eb99b1e3b0f313c0b59a66ecc7612396dc8db0ea5da13a7acomparison-004ca4a8ec71f5cdbuild-13a6e5be87bc4a53cohort-fdab2adfb8a4bd39348a7e367b8c52f1ce72828ed09c15b0e9fac38b dirtysha256:a1a935298956020ee6d767a756847abb4c00694c88c2eb80d454886ebc4acf8cNormalized reviewer-tool usage projection
Normalized assessment summary
Review text is escaped; normalized decisions follow each finding
A newly committed blob has no index until after registry registration, so a concurrent sweep treats it as orphaned, deletes it, and makes the fetch fail with a missing blob
services/proxy/src/sweep.rs:119
Evidence quote
Not recorded
Suggested fix
Not recorded
fs::metadata` follows directory symlinks, allowing the recursive sweep to traverse and delete files outside `CAIRN_BLOB_DIR`
services/proxy/src/sweep.rs:164
Evidence quote
Not recorded
Suggested fix
Not recorded
Every `incoming` file is unlinked without distinguishing active blob or index writes, so a sweep concurrent with a fetch can make its commit fail
services/proxy/src/sweep.rs:232
Evidence quote
Not recorded
Suggested fix
Not recorded
The admin route calls unlocked `sweep` directly, allowing manual requests to overlap each other and the locked background sweep, contrary to the one-at-a-time guarantee
services/proxy/src/routes/admin.rs:76
Evidence quote
Not recorded
Suggested fix
Not recorded
The synchronous recursive filesystem sweep runs directly on a Tokio worker, so a large store can block runtime capacity and stall unrelated requests
services/proxy/src/sweep.rs:84
Evidence quote
Not recorded
Suggested fix
Not recorded
Sorting elapsed ages ascending evicts the youngest eligible blobs first, opposite the documented oldest-first policy and reducing cache hit rate
services/proxy/src/sweep.rs:102
Evidence quote
Not recorded
Suggested fix
Not recorded
An unlink failure is only logged before the candidate is counted as removed, causing false reclaimed metrics and deletion of index entries for a blob still present
services/proxy/src/sweep.rs:126
Evidence quote
Not recorded
Suggested fix
Not recorded
forget` runs during dry runs, so `?dry_run=true` destructively removes index entries for projected eviction candidates
services/proxy/src/sweep.rs:140
Evidence quote
Not recorded
Suggested fix
Not recorded
Tokio interval’s first and overdue ticks resolve immediately, so the sweeper runs at startup and can run continuously back-to-back after an overrun instead of waiting a full interval
services/proxy/src/main.rs:115
Evidence quote
Not recorded
Suggested fix
Not recorded
Sweep byte and blob values are reversed relative to `COUNTERS`, so each Prometheus metric reports the other metric’s value
services/proxy/src/metrics.rs:94
Evidence quote
Not recorded
Suggested fix
Not recorded
Using `remaining >= max_bytes` evicts an eligible blob when the cache is already exactly at its allowed ceiling
services/proxy/src/sweep.rs:120
Evidence quote
Not recorded
Suggested fix
Not recorded
Open a row to inspect or download evidence from this atomically published local run
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link