afi / afi · cli reviewed proxy at 9b51f95e with Default profile / xAI · grok 4.5 high on afi 0.30.0
Unavailable values retain their exported state and reason
Lifecycle, reviewer, build, settings, and normalized execution limits
1a9fd43b245econfig-e42343de8516eb8cb0f313c0b59a66ecc7612396dc8db0ea5da13a7acomparison-041168a6e4dbca97build-4ceb7cbd44e9619bcohort-fdab2adfb8a4bd3910b3b2068100b7ba429855e062500eaf83b90120 dirtysha256:a1a935298956020ee6d767a756847abb4c00694c88c2eb80d454886ebc4acf8cNormalized reviewer-tool usage projection
Normalized assessment summary
Review text is escaped; normalized decisions follow each finding
forget()` always deletes index entries, including when `dry_run` is true, so `POST /v1/admin/cache/sweep?dry_run=true` mutates the store and turns would-be victims into cache misses.
services/proxy/src/sweep.rs:140
Evidence quote
Not recorded
Suggested fix
Not recorded
clear_partials` unlinks every file in `incoming`, including in-flight `BlobWriter` temps still being fetched; the later `rename` in `commit` then fails with ENOENT and the download is lost.
services/proxy/src/sweep.rs:224
Evidence quote
Not recorded
Suggested fix
Not recorded
sort_by_key(|c| c.age)` orders youngest→oldest, so ceiling eviction deletes the most recently written blobs first and keeps cold ones.
services/proxy/src/sweep.rs:102
Evidence quote
Not recorded
Suggested fix
Not recorded
values()` emits `sweep_bytes_reclaimed` then `sweep_blobs_removed`, but `COUNTERS` names them in the opposite order, so Prometheus scrapes swap the two series.
services/proxy/src/metrics.rs:94
Evidence quote
Not recorded
Suggested fix
Not recorded
on-demand `sweep()` calls `Sweeper::sweep` directly and skips the `running` mutex that `run()` holds, so a manual sweep can race the background sweeper and over-delete.
services/proxy/src/routes/admin.rs:76
Evidence quote
Not recorded
Suggested fix
Not recorded
the full filesystem walk/`unlink` pass runs inline on the async worker (admin handler and `run()` after `lock`), so a large store stalls the runtime and other requests for the whole sweep.
services/proxy/src/sweep.rs:90
Evidence quote
Not recorded
Suggested fix
Not recorded
tokio::time::interval` fires its first tick immediately, so the process sweeps on startup contrary to the “first tick is one interval away” guarantee in the comment above.
services/proxy/src/main.rs:108
Evidence quote
Not recorded
Suggested fix
Not recorded
a failed `remove_file` is only logged; the blob is still counted as reclaimed and its digest is still passed to `forget()`, dropping index entries while the bytes may remain on disk.
services/proxy/src/sweep.rs:126
Evidence quote
Not recorded
Suggested fix
Not recorded
Open a row to inspect or download evidence from this atomically published local run
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link