afi / afi · cli reviewed proxy at 9b51f95e with Default profile / Moonshot AI · kimi k2.7 code high on afi 0.30.0
Unavailable values retain their exported state and reason
Lifecycle, reviewer, build, settings, and normalized execution limits
372d66bf0bafconfig-b501a08ebedcc16ab0f313c0b59a66ecc7612396dc8db0ea5da13a7acomparison-14cee6e10514f39ebuild-4ceb7cbd44e9619bcohort-9159b376678f105210b3b2068100b7ba429855e062500eaf83b90120 dirtysha256:a1a935298956020ee6d767a756847abb4c00694c88c2eb80d454886ebc4acf8cNormalized reviewer-tool usage projection
Normalized assessment summary
Review text is escaped; normalized decisions follow each finding
Duration::from_hours(1)` and `Duration::from_mins(15)` do not exist on `std::time::Duration`; this code does not compile. 🔗 relevant also at services/proxy/src/config.rs:84, 350, 351.
services/proxy/src/config.rs:83
Evidence quote
Not recorded
Suggested fix
Not recorded
Sweeper::sweep` is a synchronous filesystem walk called from an async handler (`admin::sweep` at services/proxy/src/routes/admin.rs:67) without `spawn_blocking`, blocking the Tokio runtime for the… Sweeper::sweep` is a synchronous filesystem walk called from an async handler (`admin::sweep` at services/proxy/src/routes/admin.rs:67) without `spawn_blocking`, blocking the Tokio runtime for the entire duration of a large store walk.
services/proxy/src/sweep.rs:90
Evidence quote
Not recorded
Suggested fix
Not recorded
remaining` starts at `held` and is only decremented after a blob is chosen for removal, so the ceiling is compared against the pre-removal total. The first iteration removes a blob even when `held == max_bytes`, which is correct, but the loop continues removing the oldest referenced blob one byte beyond the ceiling rather than stopping once `remaining < max_bytes`. More importantly, if `held` is already below `max_bytes`, the condition `remaining >= max_bytes` is false, so no unreferenced-blob removal happens by age—but unreferenced blobs are still removed unconditionally, which is intended; the real issue is that with `held >= max_bytes`, after removing one blob, `remaining` becomes `held - size`, and if that is still >= max_bytes, another old blob is removed. This repeats until the total is strictly less than the ceiling, so the store can end up far below the configured ceiling when a single old blob is much smaller than the overage.
services/proxy/src/sweep.rs:119-120
Evidence quote
Not recorded
Suggested fix
Not recorded
age_of` returns `Duration::default()` when `modified()` is missing or in the future, treating every such blob as age zero. A blob with a bad timestamp will then never be removed by age even if the store is over its ceiling, and may silently accumulate.
services/proxy/src/sweep.rs:185-189
Evidence quote
Not recorded
Suggested fix
Not recorded
clear_partials` counts every entry in `incoming` as a removed partial even during a dry run, so `Reclaimed::partials` is non-zero in dry-run output even though nothing was deleted.
services/proxy/src/sweep.rs:224-240
Evidence quote
Not recorded
Suggested fix
Not recorded
the values array and `COUNTERS` were expanded to six entries, but the order of the new sweep counters in `values()` does not match their order in `COUNTERS`: `COUNTERS` has bytes then blobs, but… the values array and `COUNTERS` were expanded to six entries, but the order of the new sweep counters in `values()` does not match their order in `COUNTERS`: `COUNTERS` has bytes then blobs, but `values()` loads bytes then blobs as well. (Actually both have bytes then blobs at offsets 4 and 5; no mismatch.) No finding here.
services/proxy/src/metrics.rs:88-96
Evidence quote
Not recorded
Suggested fix
Not recorded
reclaim` calls `app.sweeper.sweep(dry_run)` synchronously. Because `sweep` performs blocking I/O on the async thread (see above) and is not `await`ed, this also bypasses the `Mutex` ordering established by `Sweeper::run`, though the same process mutex is still held. 🟢 `maintainability` services/proxy/src/sweep.rs:199-201: `referenced` reuses the generic recursive `collect`, which collects every file including non-JSON entries and directories; fine, but worth noting it also walks any stray directories under `index` and treats all files as candidate entries. No other concrete defects identified.
services/proxy/src/routes/admin.rs:67
Evidence quote
Not recorded
Suggested fix
Not recorded
Open a row to inspect or download evidence from this atomically published local run
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link
Open this path at the exported commit
The artifact is present; its content is available through the verified source link